Skip to content

Rename tox_pip.py to protected_pip.py #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Apr 29, 2022

This is in line with what the only point of use (in noxfile.py) calls this. I got annoyed-enough that I see this discrepency every single time I run the test suite, so... here's a PR for it!

This is in line with what the only point of use (in noxfile.py) calls
this.
This should make it easier to understand what this file is doing,
and when it is useful.
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 29, 2022
@pradyunsg pradyunsg marked this pull request as ready for review April 29, 2022 16:23
@pradyunsg
Copy link
Member Author

Heh, this doesn't run the CI. >.<

None the less, I tested this locally with a nox -s test-3.9 -- --use-venv -m unit and it worked.

@pradyunsg pradyunsg merged commit 04f754d into pypa:main Apr 29, 2022
@pradyunsg pradyunsg deleted the improve-protected-pip branch April 29, 2022 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants