Check if binary_executable exists #11318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jul 28, 2022
uranusjr
approved these changes
Jul 28, 2022
Member
|
Oh we need a news fragment. |
93578237
force-pushed
the
check-binary-exe
branch
from
b47c70c to
0f8243f
Compare
pradyunsg
reviewed
Aug 1, 2022
Contributor
|
Aside from different formatting, this is the same change as I made locally (but never got round to making a PR for). I've had no problems so far. |
pradyunsg
approved these changes
Aug 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11309