Skip to content

Deprecate --build-option and --global-option #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

Deprecate --build-option and --global-option #11861

merged 1 commit into from
Mar 27, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 12, 2023 •
edited
Loading

Towards #11859

@sbidoul sbidoul added this to the 23.1 milestone Mar 12, 2023
@sbidoul sbidoul added project: setuptools Related to setuptools type: deprecation Related to deprecation / removal. labels Mar 12, 2023
@webknjaz webknjaz added the skip news Does not need a NEWS file entry (eg: trivial changes) label Mar 12, 2023
@webknjaz webknjaz removed skip news Does not need a NEWS file entry (eg: trivial changes) bot:chronographer:provided labels Mar 12, 2023
@webknjaz webknjaz mentioned this pull request Mar 12, 2023
Merged
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Mar 18, 2023
@sbidoul sbidoul force-pushed the deprecate-build-global-option-sbi branch from 5a193a2 to 090568f Compare March 18, 2023 15:19
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 18, 2023
@sbidoul sbidoul force-pushed the deprecate-build-global-option-sbi branch from 090568f to 8d79568 Compare March 18, 2023 17:24
@pradyunsg pradyunsg force-pushed the deprecate-build-global-option-sbi branch from 8d79568 to 6adb7af Compare March 27, 2023 10:56
@pradyunsg
Copy link
Member

I've rebased this on the latest main, via the GitHub UI -- this fixes the failing platform test. :)

@sbidoul
Copy link
Member Author

sbidoul commented Mar 27, 2023

🍏 and everyone was on board, so merging.

@sbidoul sbidoul merged commit 2cf9db2 into pypa:main Mar 27, 2023
@sbidoul sbidoul deleted the deprecate-build-global-option-sbi branch March 27, 2023 15:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
project: setuptools Related to setuptools type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sbidoul @pradyunsg @uranusjr @webknjaz @pypa-bot