Skip to content

Warn if --hash is used on a line without requirement #11940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uranusjr merged 1 commit into from
Apr 10, 2023
Merged

Warn if --hash is used on a line without requirement #11940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/11935.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Warn if ``--hash`` is used on a line without requirement in a requirements file.
10 changes: 10 additions & 0 deletions src/pip/_internal/req/req_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Requirements file parsing
"""

import logging
import optparse
import os
import re
Expand Down Expand Up @@ -76,6 +77,8 @@
# the 'dest' string values
SUPPORTED_OPTIONS_REQ_DEST = [str(o().dest) for o in SUPPORTED_OPTIONS_REQ]

logger = logging.getLogger(__name__)


class ParsedRequirement:
def __init__(
Expand Down Expand Up @@ -209,6 +212,13 @@ def handle_option_line(
options: Optional[optparse.Values] = None,
session: Optional[PipSession] = None,
) -> None:
if opts.hashes:
logger.warning(
"%s line %s has --hash but no requirement, and will be ignored.",
filename,
lineno,
)

if options:
# percolate options upward
if opts.require_hashes:
Expand Down