-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add initial support for -r pylock.toml (experimental) #13876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5abc146
Add support for -r pylock.toml
sbidoul 46b27b0
-r pylock: expand --requirement help text
sbidoul 9f2b4c6
-r pylock.toml: test coverage and fixes
sbidoul ea5adf0
-r pylock.toml: add experimental warning
sbidoul 8dc6246
-r pylock.toml: add integration tests
sbidoul f5a5e46
Add news
sbidoul 9de4c4a
-r pylock: exception handling
sbidoul 5a70968
-r pylock.toml: requirements from pylock are REQUESTED
sbidoul b9c455b
-r pylock.toml: more URL validation
sbidoul b506cae
... url
sbidoul f508b79
-r pylock.toml: mention experimental status in help/docs
sbidoul b001c9f
-r pylock.toml: introduce locked link InstallRequirement
sbidoul aface0e
-r pylock.toml: add test for is_direct and requested
sbidoul 9405b36
-r pylock.toml: address minor code review comments
sbidoul 0660c69
-r pylock: expand and test no/only-binary support
sbidoul eaaa116
Add pip lock -r pylock.toml roundtrip test
sbidoul 2f7ad8c
-r pylock.toml: fix crash with pip wheel and pip lock
sbidoul 3517841
-r pylock: refine filename pylock-ness test
sbidoul ba2fc12
-r pylock.toml: proper error with remote pylock.toml containing direc…
sbidoul c335252
-r pylock.toml: add pip-wheel -r pylock.toml test
sbidoul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add experimental support to read requirements from standardized pylock.toml files (``-r pylock.toml``). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we handle
--only-finalhere, too?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
--only-finalinfluences the solver. The lock file provides pinned requirements so it is reasonable to assume the user wants to install exactly what is in it.Source/binary format control is different as it's a way to force/prevent building from source regardless of binary artifacts available in the lock file for the current platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More accurrately a way to force/prevent using source artifacts regardless of binary artifacts available in the lock file for the current platform (since the cache of locally built wheel may still provide the wheel when
--no-binaryis used)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #13950 to discuss this. I don't have a strong opinion on this.