Skip to content

Fix Pip install Error on windows("The directory is not empty") #306 #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iconberg wants to merge 4 commits into from
Closed

Fix Pip install Error on windows("The directory is not empty") #306 #2365

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e359dde
Fix Pip install Error on windows("The directory is not empty") #306
iconberg Dec 19, 2014
5449567
Update download.py
iconberg Jan 19, 2015
335fd75
Update download.py
iconberg Jan 19, 2015
04bcc07
Update download.py
iconberg Jan 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pip/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,14 @@ def unpack_http_url(link, location, download_dir=None, session=None):

if not already_downloaded_path:
os.unlink(from_path)
os.rmdir(temp_dir)

"""remove directory can fail with oserror due virus scanner locking,
try and notify user if it fails"""
try:
os.rmdir(temp_dir)
except OSError:
logger.warn('Sorry, clearing our temp files fails. '
'You may do it manually for %s', temp_dir)


def unpack_file_url(link, location, download_dir=None):
Expand Down