Do not optionally load C dependencies in requests #4035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Oct 28, 2016
|
This change made it impossible to get SNI support on Python older than 2.7.9, e.g. on Ubuntu 14.04. Was that intentional? Also, the title says optionally, but this is not optional as far as I can see. Would it be possible to make this conditional? |
|
Agreed 😞 this is problematic for installations older than 2.7.9, please consider providing a way to allow for secure urllib3/requests installations. |
5 tasks
|
Worth linking to #4098. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3024
Fixes #2930
Fixes #1840