-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Make _run_setup_py magic use pkg_resources.iter_entry_points #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egg_info.iter_entry_points, which might not be there if someone redefines egg_info (like the setup.py for pyobjc-core does) Fixes pypaGH-11
Hm, even if the tests pass, this needs a test on its own. |
@jezdez Good point. See e089e40. Here's the result of running it without and with the fix in ea109a0:
|
pnasrat
added a commit
that referenced
this pull request
Jul 2, 2012
Make _run_setup_py magic use pkg_resources.iter_entry_points
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of relying on
egg_info.iter_entry_points
, which might not be there if someoneredefines
egg_info
(like thesetup.py
in pyobjc-core does)Fixes GH-11.