Skip to content

Refactor handling of require_hashes in the Resolver+RequirementPreparer #7324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2019

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Nov 9, 2019

Toward #7317

@pradyunsg pradyunsg added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 9, 2019
@pradyunsg pradyunsg requested a review from chrahunt November 9, 2019 20:28
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good to me. I raised a PR against your fork to fix the test failures.

@chrahunt chrahunt closed this Nov 10, 2019
@chrahunt chrahunt reopened this Nov 10, 2019
@chrahunt
Copy link
Member

The RTD check is acting up, so I'll merge this as-is.

@chrahunt chrahunt merged commit d38cead into pypa:master Nov 10, 2019
@pradyunsg pradyunsg deleted the refactor/require_hashes branch November 10, 2019 05:49
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
blueyed referenced this pull request in jazzband/pip-tools Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants