Skip to content

Tweak format_size utility function to include a space #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Nov 25, 2019

Not sure about the news fragment: it is user facing but somewhat anecdotic.

@chrahunt
Copy link
Member

They're meant to be for debugging and information, so I wouldn't consider it necessary from a "changes in pip that you may have to change your build scripts for" perspective.

@xavfernandez xavfernandez added the skip news Does not need a NEWS file entry (eg: trivial changes) label Nov 25, 2019
@xavfernandez xavfernandez merged commit 9557610 into pypa:master Nov 25, 2019
@xavfernandez xavfernandez deleted the format_size branch November 25, 2019 21:09
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants