Configure tempdir registry in BaseCommand #7652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
|
Gentle nudge. This would be my pick for priority if any need a priority, since it blocks other refactoring. |
uranusjr
reviewed
Jan 29, 2020
uranusjr
reviewed
Jan 29, 2020
uranusjr
reviewed
Jan 29, 2020
uranusjr
reviewed
Jan 29, 2020
pradyunsg
approved these changes
Jan 29, 2020
|
OK as is, and the aforementioned readability issues also stuck out to me. |
Now we can opt-in to globally-managed + globally-configured file deletion for pre-existing directories by passing an explicit `None`.
Next we can actually transition some files to be globally-managed that are only deleted conditionally.
chrahunt
force-pushed
the
refactor/configure-tempdir-registry-in-command
branch
from
eb13ade to
f2af7df
Compare
|
Thank you both for reviewing. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #7608 (comment). This will let us configure and use the tempdir registry to apply the
--no-cleanconfiguration to globally managed temporary directories, and eventually remove the responsibility for managing those directories fromRequirementSet.Progresses #7571.