-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix debundled support by add a missing entry for appdirs #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I assume this doesn't need a NEWS entry / issue, but I'd be happy to create them if wanted. |
appdirs was vendored much earlier than #7501 it was used bu another vendored lib), that PR only dropped the duplicated functionality :p Nonetheless, thanks for catching this! |
@pradyunsg, do we want to include this in 20.x? |
I'm on board. Since we're probably going to be making a release for the PyPy tags anyway, I'll be happy to include this in the release as well. :) |
@lazka, can you please add a bugfix news entry for this? |
09ffd07
to
e1fb489
Compare
pip has started to use the vendored appdirs directly since pypa#7501 but didn't add an alias for the unbundled case. This adds the missing alias.
e1fb489
to
9be7454
Compare
@chrahunt done |
@chrahunt I don't think this should get a .bugfix entry, since debundling is "semi-supported". I'd prefer that we don't call this out in NEWS at all or, at best, call this out in our vendoring details (i.e. a I'll merge this PR now, since I don't think the discussion on where the NEWS entry should be is a blocker for this PR. I'll file a follow-up PR where we can discuss that. :) |
Thanks for the PR @lazka! ^>^ |
pip has started to use the vendored appdirs directly since #7501
but didn't add an alias for the unbundled case.
This adds the missing alias.
Before the fix: