Fix unpack directory contains symlinks on py3k #813
Conversation
|
|
||
| exc = None; | ||
|
|
||
| try: |
There was a problem hiding this comment.
A try with run_pip() and finally with the removes looks better, and no except statement, like other tests.
|
After reading issues list I've seen this PR fix #611 |
| shutil.copytree(source, location) | ||
| # The py3k version of `shutil.copytree` fails when symlinks point on | ||
| # directories. So `symlinks` argument must be True | ||
| shutil.copytree(source, location, symlinks=True) |
There was a problem hiding this comment.
Does symlinks=True work on Windows? Specifically, I assume copytree doesn't fail if symlinks=True is set, and if symlinks are present, what is the behaviour? Note that creating symlinks on Windows requires an elevated process, which most Python processes won't be...
Symlinks on Windows are rare, so the main issue here is that this change doesn't stop the normal (non-symlink) case working on Windows.
There was a problem hiding this comment.
shutil.copytree on py2
http://hg.python.org/cpython/file/2.7/Lib/shutil.py#l145
shutil.copytree on py3
http://hg.python.org/cpython/file/3.3/Lib/shutil.py#l259
The shutil.copytree function on py3 don't care about if the file pointed by a symlink is a directory or a file. It passed to copy_function (copy2 by default) and so fails with a directory.
symlinks=True is same as follow_symlinks=False
With this fix all symlinks on the source directory are not followed. It break the current behaviour indeed. So for keep the current behaviour we need to do that: alquerci@66a0cef2e11fe1f057c68ba716a55978b0e982ec
What is the better behaviour in your mind?
|
closing this, so we can focus on #1311 . |
lock
bot
added
the
auto-locked
Hello,
On python3 installation fail when the source directory contains symlinks.
See: https://api.travis-ci.org/jobs/4900020/log.txt?deansi=true
Before apply this fix tests fails on py32 and py33. https://travis-ci.org/alquerci/pip/builds/4980091
Symbolic links are not followed.