Skip to content

Ignore require-virtualenv in pip cache #8157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

Ignore require-virtualenv in pip cache #8157

merged 1 commit into from
Apr 28, 2020

Conversation

pradyunsg
Copy link
Member

Pointed out by @uranusjr during a discussion about this new command.

@pradyunsg pradyunsg added the !release blocker Hold a release until this is resolved label Apr 28, 2020
@pradyunsg pradyunsg added this to the 20.1 milestone Apr 28, 2020
@pradyunsg pradyunsg requested a review from pfmoore April 28, 2020 13:47
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 28, 2020
pfmoore
pfmoore approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pradyunsg pradyunsg mentioned this pull request Apr 28, 2020
Closed
@pradyunsg pradyunsg merged commit 371d6f5 into pypa:master Apr 28, 2020
@pradyunsg pradyunsg deleted the cache/ignore-require-venv branch April 28, 2020 15:22
@uranusjr uranusjr mentioned this pull request Apr 28, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
!release blocker Hold a release until this is resolved skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pradyunsg @pfmoore