Remove redundant entrypoint text normalization #8528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we do processing in `get_entrypoints` so incoming text is more compatible with `pkg_resources`. It turns out that `pkg_resources` is already doing the same normalization, so we can omit it. This simplifies `get_entrypoints`, opening the way for us to pass it a plain string instead of a file path.
chrahunt
added
the
skip news
pradyunsg
reviewed
Jul 3, 2020
|
(I blame my patchy Internet connection) |
|
Thanks for reviewing. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to submit this PR separately since the justification requires a little bit of a code dive. I hope that helps!
Currently we do processing in
get_entrypointsso incoming text is more compatiblewith
pkg_resources. It turns out thatpkg_resourcesis already doing the same normalization,so we can omit it. See
parse_map, which callssplit_sections, which callssplit_sections, which callsyield_lines, where it accepts plain text and strips lines, as we were doing.This simplifies
get_entrypoints, opening the way for us to pass it a plain string (derived from the zip file) insteadof a file path.
Progresses #6030.