Do not extract wheels in requirement preparation #8552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some time we have not needed to pre-emptively unpack wheels as part of metadata processing, but kept the existing logic because the behavior would start to diverge more for different package types. In this case, though, removing the special cases for wheels makes this logic a bit simpler, so it is worth doing.
chrahunt
added
type: refactor
pfmoore
approved these changes
Jul 7, 2020
sbidoul
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some time we haven't needed to extract wheels during requirement preparation, but were doing it anyway. Now we don't!
Progresses #6030.