Skip to content

chore: use subprocess.run instead of old check_* #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/pyproject_hooks/_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
import os
import sys
import tempfile
import subprocess
from contextlib import contextmanager
from os.path import abspath
from os.path import join as pjoin
from subprocess import STDOUT, check_call, check_output
from typing import TYPE_CHECKING, Any, Iterator, Mapping, Optional, Sequence
import warnings

Expand Down Expand Up @@ -79,13 +79,13 @@ def default_subprocess_runner(
) -> None:
"""The default method of calling the wrapper subprocess.

This uses :func:`subprocess.check_call` under the hood.
This uses :func:`subprocess.run` under the hood.
"""
env = os.environ.copy()
if extra_environ:
env.update(extra_environ)

check_call(cmd, cwd=cwd, env=env)
subprocess.run(cmd, cwd=cwd, env=env, check=True)


def quiet_subprocess_runner(
Expand All @@ -95,13 +95,20 @@ def quiet_subprocess_runner(
) -> None:
"""Call the subprocess while suppressing output.

This uses :func:`subprocess.check_output` under the hood.
This uses :func:`subprocess.run` with `stdout=PIPE, stderr=STDOUT` under the hood.
"""
env = os.environ.copy()
if extra_environ:
env.update(extra_environ)

check_output(cmd, cwd=cwd, env=env, stderr=STDOUT)
subprocess.run(
cmd,
cwd=cwd,
env=env,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
check=True,
)


def norm_and_check(source_tree: str, requested: str) -> str:
Expand Down
Loading