Forward warning options to subprocess #216
Open
+35
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by the discussions in:
The main idea is to forward whichever warning options have been specified for the "parent" process to the subprocess, as a complement to #157 1.
For example, if the user passes
python -W ignore -m build
, then_in_process.py
would also be called with-W ignore
.This is an initial investigation to test the waters, it can be incrementally improved based on feedback.
One thing that I considered is a finer control over the warnings or allowing the API callers to customise the values. But I rejected this idea as over engineering. Based on YAGNI, we can implement something very simple.
Footnotes
This way frontends could re-use Python's UI for warning filters without the necessity to implement their own. (They can still implement it if they want, but re-using Python's is handy). ↩