Support in tree hooks (pyproject.toml backend-path key) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
takluyver
reviewed
Mar 17, 2019
|
@takluyver I believe that's all the review comments addressed. Sorry it took so long. Are there any other issues you think need addressing? |
takluyver
reviewed
Apr 27, 2019
| if self.backend_path: | ||
| backend_path = os.pathsep.join(self.backend_path) | ||
| if sys.version_info[0] == 2: | ||
| backend_path = backend_path.encode(sys.getfilesystemencoding()) |
There was a problem hiding this comment.
This may fail if a Unix filesystem erroneously reports that it's ASCII and someone tries to use a non-ASCII path. But I don't know what the correct thing to do on Python 2 in that case is (Python 3 has os.fsencode()). So we may as well cross our fingers and hope people use either Python 3 or plain ASCII paths.
|
Thanks, I think it looks good. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.