-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding codecov configuration #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added minimal configuration
We'll need to wait for @jaraco to allow the CI run, I don't have access to that button. But looks good otherwise. |
Updating from GH UI Co-authored-by: Sviatoslav Sydorenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks acceptable. I don't yet see any results in the runners. I'll probably remove all of the options that aren't necessary and trust that the defaults are good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like codecov isn't finding any coverage reports. See if you can find a way to retain those artifacts for upload, preferably without altering any existing lines.
GHA logs have this:
🤔 Does it expect that |
Flags are necessary because these are useful in the report view showing what envs hit certain lines. So plz recover that option. And disabling gcov sounds right too. You can also specify |
Looks like it's exactly what it expects: the README example shows installing+running pytest-cov in a bare env (w/o a venv created by tox). |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@tanvimoharir could you recover the action options under @jaraco you'll need to re-approve the CI run for us to see if the patch works. |
Thanks, I have added back the actions options per your earlier comment. |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
…e reports using the default filename.
Thanks for the diligent work on putting this together. |
Summary of changes
Added minimal configuration for codecov.
Closes #2642
Pull Request Checklist
Changes have tests (N/A)
News fragment added in [
changelog.d/
]. (N/A?)(See [documentation][PR docs] for details)
I have hereby reviewed ,and agree to follow, the PSF Code of Conduct