-
Notifications
You must be signed in to change notification settings - Fork 318
Twine 3.8 - missing install requirement #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Weird. I get the same error after running That said, this has been fixed in Twine 4.0.0, specifically c506b22, which removed the |
Yes, thanks @bhrutledge , the upgrade to 4.0.0 does solve the issue. I'm happy if you want to close this issue. |
What? Your issue, this ticket and the linked ticket are three different things. |
«Stack» is a very generic programming term. The website you are referring to is called Stack Overflow, or short SO. Nobody calls it stack. This is the Twine repo on Github, it has no relation with Stack Overflow. Complaining about another site’s policies is fruitless. |
Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
* change: adjust tox black stages to install from requirements file Also remove uneeded config in the command, it is now set in the pyproject.toml so IDE's and other tooling outside tox picks up the setting. * change: improve tox install times by not installing all deps when not needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes #4591 * change: bump twine version to 5.0.0 Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
* change: adjust tox black stages to install from requirements file Also remove uneeded config in the command, it is now set in the pyproject.toml so IDE's and other tooling outside tox picks up the setting. * change: improve tox install times by not installing all deps when not needed Moved to using deps to override the test extra being installed in skip_install tox stages. Now only the needed deps are installed. Improves install time by around 7x. Closes aws#4591 * change: bump twine version to 5.0.0 Twine 3.8.0 didn't include its dependencies. The tox stage happened to work from packaging being installed as a transitive. Ref: pypa/twine#894
Environment
Operating system:
Ubuntu 20.04
Version of python:
3.8
Twine installed method
pip install twine
Version of twine:
twine-3.8.0-py3-none-any.whl
Target repository for twine to upload to?
pypi
The Issue
The "twine upload" command breaks with stacktrace:
Workaround
install the "packaging" package manually: pip install packaging
Proposed fix:
Add "packing" to install_requires section in https://github.com/pypa/twine/blob/main/setup.cfg
Steps to Reproduce
create a new python virtualenv without installing any packages except twine
It seems that if you install tox, tox installs the missing package twine itself requires(packaging). So not installing tox in an environment and only installing twine, reproduces the error:
pip install twine
twine upload --skip-existing -r pypi sample-1.0.0-py3-none-any.whl sample-1.0.0-py3-none-any.whl.asc
This command will break and indicated above.
The text was updated successfully, but these errors were encountered: