Lint activate.ps1 #1373
Merged
Lint activate.ps1 #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now passes the following two commands Invoke-ScriptAnalyzer activate.ps1
Invoke-ScriptAnalyzer -Setting CodeFormattingOTBS activate.ps1 |
|
Note that while the tests pass, I dont have Windows so I havent played with this. I do have pwsh for Linux, and I could test with that if it is known to work (and add tests for that?) It should be reviewed by someone who can verify that it works correctly, or identify extra tests that need to be written to verify it is working correctly. |
|
please run tox -e embed and commit the generated change |
|
I got a non-zero exit code, but I guess that is OK. > python3 -m tox -e embed
embed create: /home/jayvdb/projects/python/virtualenv/.tox/embed
embed installdeps: pip >= 19.1.1
embed run-test-pre: PYTHONHASHSEED='4009722547'
embed run-test: commands[0] | python update_embedded.py
Found file site.py
File up to date (crc: 458366c2)
Found file activate.sh
File up to date (crc: 0d63b5ff)
Found file activate.fish
File up to date (crc: e5f7c440)
Found file activate.csh
File up to date (crc: ff2bf2f5)
Found file activate.xsh
File up to date (crc: fec22784)
Found file activate.bat
File up to date (crc: 0f734cb0)
Found file deactivate.bat
File up to date (crc: 9ddc164f)
Found file activate.ps1
Content changed (crc: d8005bb6 -> c7bc785c)
Found file distutils-init.py
File up to date (crc: affaad52)
Found file distutils.cfg
File up to date (crc: cd607b02)
Found file activate_this.py
File up to date (crc: 544ed6ab)
Found file python-config
File up to date (crc: 9a7177a5)
Content updated; overwriting... done.
ERROR: InvocationError for command /home/jayvdb/projects/python/virtualenv/.tox/embed/bin/python update_embedded.py (exited with code 1)
________________________________________________________________________________ summary _________________________________________________________________________________
ERROR: embed: commands failed |
|
Updated to use the default style, called |
Fix PSScriptAnalyzer warnings, and follow style from -Setting CodeFormatting Closes pypa#1371
|
It looks like the CI error isnt related to my changes. Please correct me if I am wrong about that. |
gaborbernat
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PSScriptAnalyzer warnings, and follow style from
-Setting CodeFormattingOTBS
Closes #1371