Simplify Solution to --python command-line flag precedence#2826
Merged
gaborbernat merged 1 commit intomainfrom Jan 17, 2025
unknown repository
Merged
Simplify Solution to --python command-line flag precedence#2826gaborbernat merged 1 commit intomainfrom unknown repository
gaborbernat merged 1 commit intomainfrom
unknown repository
Conversation
* Update virtualenv/discovery/builtin.py - simplify solution by operating on the sequence directly without creating a deque
Author
|
I noticed this commit in the most recent release of virtualenv. Reviewing the commit, I thought I could quickly simplify it. |
gaborbernat
approved these changes
Jan 16, 2025
ghost
marked this pull request as ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update virtualenv/discovery/builtin.py
Simplify solution by operating on the sequence directly without creating a deque.
TODO
tox -e fix)docs/changelogfolder