Fix --always-copy #511
Merged
Fix --always-copy #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead full path; use local copyfile() function to update file permissions
1) let it run for windows; should be harmless 2) confirm files and dirs are not links 3) create the tmp venvs in a *new* directory 4) if a symlink is found, report what it's linked to
2) copyfile(symlink=True) is a suitable replacement for os.symlink
This was referenced Dec 6, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a slight makeover of PR #496 for fixing #495
It fixes the 3rd commit from #496: vldmit@ec05a4e. that was mistakenly using
copyfileordir, instead ofcopyfile.Despite some confusion in the conversation in #496, the idea of the 3rd commit was necessary to make the
--always-copywork correctly for the "posix_local" scheme (which e.g. travis uses for py27 tests. to the see the failure w/o this change, see https://travis-ci.org/pypa/virtualenv/jobs/15023174 )also, made some tweaks to the test.