Fix issue #93 - Tcl doesn't work inside a virtualenv on Windows #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.3.5 still ships with Tcl 8.5, so the Python 3.3 build on Windows failed. [1] From CPython's log, Tcl 8.6.1 was introduced in Python 3.4.0 [2] But anyway I think relying on CPython version is fragile. [1] https://ci.appveyor.com/project/yan12125/virtualenv/build/job/9h8crh9s4k7ag6pb |
techtonik
added a commit
to techtonik/virtualenv
that referenced
this pull request
May 29, 2016
Closed
|
@yan12125 I don't have time to test it - edited on GitHub, so can you take a look if it at least doesn't break anything? |
This was referenced Jun 10, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies:
Checked that Python 3.4 contains the same dirs as 3.5.