bdist_wheel failing with setuptools with bad wheel name

[OmSaran]

python setup.py bdist_wheel uses bdist_wheel.py from wheel package. Since version 0.32.0 it no longer works with version names that does not match https://github.com/pypa/wheel/blob/master/wheel/wheelfile.py#L16:L19

Version names not matching the above regex did not fail with older versions of wheel.
Also PEP 427 does not enforce using PEP 440 standard version names.

[benoit-pierre]

What's the name of your wheel?

[benoit-pierre]

FYI, this is the regex used by pip: https://github.com/pypa/pip/blob/master/src/pip/_internal/wheel.py#L572

Way more lax indeed...

[agronholm]

Need more information. Can you point me to your project or at least give the name of the wheel name?

[OmSaran]

@agronholm
The version name is branch_commit
This is the error seen with wheel version > 0.32.0

wheel.cli.WheelError: Bad wheel filename 'TestProject-branch_commit-py2-none-any.whl'

The same works fine with wheel version <= 0.31.1

@benoit-pierre
The regex used in pip was relaxed via pypa/pip#4384
(refer pypa/pip#4169)

[agronholm]

@OmSaran Can you verify that the fix works for you?

[OmSaran]

@agronholm It works, thanks for the fix!!