Skip to content

Add New Spectrograph: LDT/DeVeny #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 1, 2021
Merged

Add New Spectrograph: LDT/DeVeny #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5baeaf4
Add LDT / DeVeny Spectrograph class
tbowers7 Apr 19, 2021
21ae89b
Add full set of telescope paramters for LDT
tbowers7 Jun 21, 2021
18b6c58
Separate 'science' and 'standard' frametypes for LDT/DeVeny
tbowers7 May 28, 2021
2478f6e
Add DeVeny dark current measurement
tbowers7 Jun 4, 2021
b258430
Remove all exposure time ranges for frame typing
tbowers7 Jun 22, 2021
71deb2c
LDT/DeVeny supported = True
tbowers7 Jun 21, 2021
1245763
Add CdI line at 6440.2490Å from NIST line list
tbowers7 Mar 3, 2021
e78d17f
Add reid_arxiv template for DV5 grating
tbowers7 Jun 18, 2021
2a640b9
Add unit test to tickle I/O for LDT/DeVeny
tbowers7 Jun 22, 2021
7838564
Add new Cooked file to test_cooked.py
tbowers7 Jun 25, 2021
4d6687b
Add these changes to CHANGES.rst
tbowers7 Jun 25, 2021
c88f5b6
Doc updates for PR
tbowers7 Jun 25, 2021
8e7e5dc
Merge branch 'develop' of https://github.com/pypeit/PypeIt into add_l…
tbowers7 Jun 25, 2021
27686cb
Fix spurious documentation changes
tbowers7 Jun 25, 2021
a8aa5fd
Revert Cooked data test
tbowers7 Jun 25, 2021
c594a29
Adjust image combination methods for calibrations
tbowers7 Jun 25, 2021
612432a
Merge branch 'develop' of https://github.com/pypeit/PypeIt into add_l…
tbowers7 Jun 25, 2021
9173ac4
Modify doc to reflect change in image combination parameters
tbowers7 Jun 26, 2021
57f4b08
Merge branch 'develop' into add_ldt_deveny
tbowers7 Jun 29, 2021
eebd202
Merge branch 'develop' of https://github.com/pypeit/PypeIt into add_l…
tbowers7 Jun 30, 2021
63ce917
Responding to change requests in PR
tbowers7 Jun 30, 2021
194610a
Addressing PR Change Requests
tbowers7 Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
`pypeit.core.wavecal.wvutils.get_wave_grid`
- `pypeit.core.coadd.sensfunc_weights` ->
`pypeit.sensfunc.sensfunc_weights`
- Add LDT/DeVeny spectrograph
- Add 6440.25A CdI line (LDT/DeVeny)


1.4.1 (11 Jun 2021)
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ Conduct](https://pypeit.readthedocs.io/en/latest/codeconduct.html).
* Keck/NIRSPEC (low-dispersion)
* LBT/Luci-I, Luci-II
* LBT/MODS (beta)
* LDT/DeVeny
* Lick/APF (planned)
* NOT/ALFOSC (grism4)
* VLT/X-Shooter
Expand Down
8 changes: 8 additions & 0 deletions doc/api/pypeit.spectrographs.ldt_deveny.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
pypeit.spectrographs.ldt\_deveny module
=======================================

.. automodule:: pypeit.spectrographs.ldt_deveny
:members:
:private-members:
:undoc-members:
:show-inheritance:
1 change: 1 addition & 0 deletions doc/api/pypeit.spectrographs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Submodules
pypeit.spectrographs.keck_nirspec
pypeit.spectrographs.lbt_luci
pypeit.spectrographs.lbt_mods
pypeit.spectrographs.ldt_deveny
pypeit.spectrographs.magellan_fire
pypeit.spectrographs.magellan_mage
pypeit.spectrographs.mdm_osmos
Expand Down
16 changes: 8 additions & 8 deletions doc/help/pypeit_chk_for_calibs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
keck_lris_red, keck_lris_red_orig, keck_mosfire,
keck_nires, keck_nirspec_low, lbt_luci1, lbt_luci2,
lbt_mods1b, lbt_mods1r, lbt_mods2b, lbt_mods2r,
magellan_fire, magellan_fire_long, magellan_mage,
mdm_osmos_mdm4k, mmt_binospec, mmt_bluechannel,
mmt_mmirs, not_alfosc, ntt_efosc2, p200_dbsp_blue,
p200_dbsp_red, p200_tspec, shane_kast_blue,
shane_kast_red, shane_kast_red_ret, soar_goodman_red,
tng_dolores, vlt_fors2, vlt_sinfoni, vlt_xshooter_nir,
vlt_xshooter_uvb, vlt_xshooter_vis, wht_isis_blue,
wht_isis_red (default: None)
ldt_deveny, magellan_fire, magellan_fire_long,
magellan_mage, mdm_osmos_mdm4k, mmt_binospec,
mmt_bluechannel, mmt_mmirs, not_alfosc, ntt_efosc2,
p200_dbsp_blue, p200_dbsp_red, p200_tspec,
shane_kast_blue, shane_kast_red, shane_kast_red_ret,
soar_goodman_red, tng_dolores, vlt_fors2, vlt_sinfoni,
vlt_xshooter_nir, vlt_xshooter_uvb, vlt_xshooter_vis,
wht_isis_blue, wht_isis_red (default: None)
-e EXTENSION, --extension EXTENSION
File extension; compression indicators (e.g. .gz) not
required. (default: .fits)
Expand Down
16 changes: 8 additions & 8 deletions doc/help/pypeit_obslog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@
keck_lris_red, keck_lris_red_orig, keck_mosfire,
keck_nires, keck_nirspec_low, lbt_luci1, lbt_luci2,
lbt_mods1b, lbt_mods1r, lbt_mods2b, lbt_mods2r,
magellan_fire, magellan_fire_long, magellan_mage,
mdm_osmos_mdm4k, mmt_binospec, mmt_bluechannel,
mmt_mmirs, not_alfosc, ntt_efosc2, p200_dbsp_blue,
p200_dbsp_red, p200_tspec, shane_kast_blue,
shane_kast_red, shane_kast_red_ret, soar_goodman_red,
tng_dolores, vlt_fors2, vlt_sinfoni, vlt_xshooter_nir,
vlt_xshooter_uvb, vlt_xshooter_vis, wht_isis_blue,
wht_isis_red
ldt_deveny, magellan_fire, magellan_fire_long,
magellan_mage, mdm_osmos_mdm4k, mmt_binospec,
mmt_bluechannel, mmt_mmirs, not_alfosc, ntt_efosc2,
p200_dbsp_blue, p200_dbsp_red, p200_tspec,
shane_kast_blue, shane_kast_red, shane_kast_red_ret,
soar_goodman_red, tng_dolores, vlt_fors2, vlt_sinfoni,
vlt_xshooter_nir, vlt_xshooter_uvb, vlt_xshooter_vis,
wht_isis_blue, wht_isis_red

optional arguments:
-h, --help show this help message and exit
Expand Down
16 changes: 8 additions & 8 deletions doc/help/pypeit_setup.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@
keck_lris_red, keck_lris_red_orig, keck_mosfire,
keck_nires, keck_nirspec_low, lbt_luci1, lbt_luci2,
lbt_mods1b, lbt_mods1r, lbt_mods2b, lbt_mods2r,
magellan_fire, magellan_fire_long, magellan_mage,
mdm_osmos_mdm4k, mmt_binospec, mmt_bluechannel,
mmt_mmirs, not_alfosc, ntt_efosc2, p200_dbsp_blue,
p200_dbsp_red, p200_tspec, shane_kast_blue,
shane_kast_red, shane_kast_red_ret, soar_goodman_red,
tng_dolores, vlt_fors2, vlt_sinfoni, vlt_xshooter_nir,
vlt_xshooter_uvb, vlt_xshooter_vis, wht_isis_blue,
wht_isis_red (default: None)
ldt_deveny, magellan_fire, magellan_fire_long,
magellan_mage, mdm_osmos_mdm4k, mmt_binospec,
mmt_bluechannel, mmt_mmirs, not_alfosc, ntt_efosc2,
p200_dbsp_blue, p200_dbsp_red, p200_tspec,
shane_kast_blue, shane_kast_red, shane_kast_red_ret,
soar_goodman_red, tng_dolores, vlt_fors2, vlt_sinfoni,
vlt_xshooter_nir, vlt_xshooter_uvb, vlt_xshooter_vis,
wht_isis_blue, wht_isis_red (default: None)
-r ROOT, --root ROOT Root to search for data files. You can provide the top-
level directory (e.g., /data/Kast) or the search string
up through the wildcard (.e.g, /data/Kast/b). Use the
Expand Down
8 changes: 4 additions & 4 deletions doc/help/pypeit_trace_edges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
keck_lris_blue_orig, keck_lris_red, keck_lris_red_orig,
keck_mosfire, keck_nires, keck_nirspec_low, lbt_luci1,
lbt_luci2, lbt_mods1b, lbt_mods1r, lbt_mods2b,
lbt_mods2r, magellan_fire, magellan_fire_long,
magellan_mage, mdm_osmos_mdm4k, mmt_binospec,
mmt_bluechannel, mmt_mmirs, not_alfosc, ntt_efosc2,
p200_dbsp_blue, p200_dbsp_red, p200_tspec,
lbt_mods2r, ldt_deveny, magellan_fire,
magellan_fire_long, magellan_mage, mdm_osmos_mdm4k,
mmt_binospec, mmt_bluechannel, mmt_mmirs, not_alfosc,
ntt_efosc2, p200_dbsp_blue, p200_dbsp_red, p200_tspec,
shane_kast_blue, shane_kast_red, shane_kast_red_ret,
soar_goodman_red, tng_dolores, vlt_fors2, vlt_sinfoni,
vlt_xshooter_nir, vlt_xshooter_uvb, vlt_xshooter_vis,
Expand Down
2 changes: 1 addition & 1 deletion doc/help/pypeit_view_fits.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
keck_lris_blue_orig, keck_lris_red, keck_lris_red_orig,
keck_mosfire, keck_nires, keck_nirspec_low, lbt_luci1,
lbt_luci2, lbt_mods1b, lbt_mods1r, lbt_mods2b, lbt_mods2r,
magellan_fire, magellan_fire_long, magellan_mage,
ldt_deveny, magellan_fire, magellan_fire_long, magellan_mage,
mdm_osmos_mdm4k, mmt_binospec, mmt_bluechannel, mmt_mmirs,
not_alfosc, ntt_efosc2, p200_dbsp_blue, p200_dbsp_red,
p200_tspec, shane_kast_blue, shane_kast_red,
Expand Down
2 changes: 1 addition & 1 deletion doc/help/run_pypeit.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
## keck_hires_red, keck_kcwi, keck_lris_blue, keck_lris_blue_orig,
## keck_lris_red, keck_lris_red_orig, keck_mosfire, keck_nires,
## keck_nirspec_low, lbt_luci1, lbt_luci2, lbt_mods1b, lbt_mods1r,
## lbt_mods2b, lbt_mods2r, magellan_fire, magellan_fire_long,
## lbt_mods2b, lbt_mods2r, ldt_deveny, magellan_fire, magellan_fire_long,
## magellan_mage, mdm_osmos_mdm4k, mmt_binospec, mmt_bluechannel,
## mmt_mmirs, not_alfosc, ntt_efosc2, p200_dbsp_blue, p200_dbsp_red,
## p200_tspec, shane_kast_blue, shane_kast_red, shane_kast_red_ret,
Expand Down
1 change: 1 addition & 0 deletions doc/include/spectrographs_table.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ lbt_mods1b :class:`~pypeit.spectrographs.lbt_mods.LBTMODS1BSpectr
lbt_mods1r :class:`~pypeit.spectrographs.lbt_mods.LBTMODS1RSpectrograph` LBT MODS1R MultiSlit True MODS-I red spectrometer
lbt_mods2b :class:`~pypeit.spectrographs.lbt_mods.LBTMODS2BSpectrograph` LBT MODS2B MultiSlit True MODS-II blue spectrometer
lbt_mods2r :class:`~pypeit.spectrographs.lbt_mods.LBTMODS2RSpectrograph` LBT MODS2R MultiSlit True MODS-II red spectrometer
ldt_deveny :class:`~pypeit.spectrographs.ldt_deveny.LDTDeVenySpectrograph` LDT deveny MultiSlit True LDT DeVeny Optical Spectrograph
magellan_fire :class:`~pypeit.spectrographs.magellan_fire.MagellanFIREEchelleSpectrograph` MAGELLAN FIRE Echelle True Magellan/FIRE in echelle mode
magellan_fire_long :class:`~pypeit.spectrographs.magellan_fire.MagellanFIRELONGSpectrograph` MAGELLAN FIRE MultiSlit True Magellan/FIRE in long-slit/high-throughput mode
magellan_mage :class:`~pypeit.spectrographs.magellan_mage.MagellanMAGESpectrograph` MAGELLAN MagE Echelle True See :doc:`mage`
Expand Down
1 change: 1 addition & 0 deletions doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ What this version provides
* LBT/Luci-I
* LBT/Luci-II
* LBT/MODS
* LDT/DeVeny
* MDM/OSMOS
* MMT/MMIRS
* MMT/binospec
Expand Down
89 changes: 89 additions & 0 deletions doc/pypeit_par.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3234,6 +3234,95 @@ Alterations to the default parameters are::
[flexure]
spec_method = boxcar

LDT deveny (``ldt_deveny``)
---------------------------
Alterations to the default parameters are::

[rdx]
spectrograph = ldt_deveny
[calibrations]
bpm_usebias = True
[[biasframe]]
[[[process]]]
apply_gain = False
combine = median
use_biasimage = False
use_pixelflat = False
use_illumflat = False
[[darkframe]]
[[[process]]]
apply_gain = False
use_biasimage = False
use_overscan = False
use_pixelflat = False
use_illumflat = False
[[arcframe]]
[[[process]]]
cr_sigrej = -1
use_pixelflat = False
use_illumflat = False
[[tiltframe]]
[[[process]]]
cr_sigrej = -1
use_pixelflat = False
use_illumflat = False
[[pixelflatframe]]
[[[process]]]
combine = median
satpix = nothing
use_pixelflat = False
use_illumflat = False
[[pinholeframe]]
[[[process]]]
use_illumflat = False
[[alignframe]]
[[[process]]]
satpix = nothing
cr_sigrej = -1
use_pixelflat = False
use_illumflat = False
[[traceframe]]
[[[process]]]
use_pixelflat = False
use_illumflat = False
[[illumflatframe]]
[[[process]]]
satpix = nothing
use_pixelflat = False
use_illumflat = False
[[skyframe]]
[[[process]]]
mask_cr = True
use_illumflat = False
[[standardframe]]
[[[process]]]
mask_cr = True
use_illumflat = False
[[wavelengths]]
ech_fix_format = False
lamps = NeI, ArI, CdI, HgI
sigdetect = 10.0
fwhm_fromlines = True
rms_threshold = 0.5
n_first = 3
n_final = 5
[[slitedges]]
sync_predict = nearest
bound_detector = True
minimum_slit_length = 90.0
[[tilts]]
spat_order = 4
spec_order = 5
[scienceframe]
[[process]]
mask_cr = True
use_illumflat = False
[reduce]
[[findobj]]
sig_thresh = 5.0
[sensfunc]
polyorder = 7

MAGELLAN FIRE (``magellan_fire``)
---------------------------------
Alterations to the default parameters are::
Expand Down
3 changes: 2 additions & 1 deletion pypeit/data/arc_lines/lists/CdI_lines.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Creation Date: 2016-Dec-21
# Creation Date: 2021-Jun-17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line below that gives a different creation date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I was following other linelists that showed multiple creation dates (e.g., ArI, HgI, CuI, etc.).

# VACUUM -- MUST BE IN NIST
| ion | wave | NIST | Instr | amplitude | Source |
| CdI | 3261.9951 | 1 | 2 | 11126.0 | lrisb_600_4000_PYPIT.json |
Expand All @@ -8,3 +8,4 @@
| CdI | 4679.4587 | 1 | 4 | 2640.0 | kastb_600_PYPIT.json |
| CdI | 4801.2540 | 1 | 6 | 25017.0 | lrisb_600_4000_PYPIT.json |
| CdI | 5087.2393 | 1 | 6 | 28781.0 | lrisb_600_4000_PYPIT.json |
| CdI | 6440.2490 | 1 | 0 | 5000.0 | NIST / LDT_DeVeny / TPEB |
Binary file added pypeit/data/arc_lines/reid_arxiv/ldt_deveny_500l_HgCdAr.fits
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion pypeit/par/pypeitpar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4604,7 +4604,7 @@ def valid_telescopes():
Return the valid telescopes.
"""
return [ 'GEMINI-N','GEMINI-S', 'KECK', 'SHANE', 'WHT', 'APF', 'TNG', 'VLT', 'MAGELLAN', 'LBT', 'MMT',
'KPNO', 'NOT', 'P200', 'BOK', 'GTC', 'SOAR', 'NTT']
'KPNO', 'NOT', 'P200', 'BOK', 'GTC', 'SOAR', 'NTT', 'LDT']

def validate(self):
pass
Expand Down
1 change: 1 addition & 0 deletions pypeit/spectrographs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from pypeit.spectrographs import keck_nirspec
from pypeit.spectrographs import lbt_luci
from pypeit.spectrographs import lbt_mods
from pypeit.spectrographs import ldt_deveny
from pypeit.spectrographs import magellan_fire
from pypeit.spectrographs import magellan_mage
from pypeit.spectrographs import mdm_osmos
Expand Down
Loading