Skip to content

Status indicator: bad layout on narrow screen #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Carreau opened this issue Jun 16, 2016 · 3 comments
Closed

Status indicator: bad layout on narrow screen #1277

Carreau opened this issue Jun 16, 2016 · 3 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented Jun 16, 2016

Cf screenshot

screen shot 2016-06-15 at 18 07 34

Seem to be because of the css-rule:

.status-badge:last-child {
    margin-right: 0;
}

and

@media only screen and (max-width: 1200px)
.status-badge:last-child {
    margin-right: 0;
}

of _span-columns.scss

Sidenote, I see the the responsive css has transitions at: 300,400, 450, 550, 600, 640, 700, 750, 800, 900, 950, 1000, 1150, 1200 px and 37.64 em. that makes 16 with on which warehouse should potentially be visually tested for defect. Is that on purpose ? For comparison chrome dev-inspector predefined "only" 6 critical width.

screen shot 2016-06-15 at 18 14 10

@nlhkabu
Copy link
Contributor

nlhkabu commented Jun 17, 2016

Thanks for flagging this @Carreau

I have not fixed this issue because I was planning on changing the design... because:

Also, it's unlikely we're going to land this before launch, so I need to find a way to separate the first badge out from the rest that will not be shown.

Thanks also for flagging the breakpoint issue. This has been addressed in #1263

@nlhkabu
Copy link
Contributor

nlhkabu commented Jun 30, 2016

I'm going to close this issue as the breakpoint issue has now been fixed and the indicators will be removed as per #1308.

Thanks for flagging this.

@nlhkabu nlhkabu closed this as completed Jun 30, 2016
@Carreau
Copy link
Contributor Author

Carreau commented Jun 30, 2016

Thanks you, and thanks a lot for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants