Skip to content

Css refactor #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 17, 2016
Merged

Css refactor #1263

merged 19 commits into from
Jun 17, 2016

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Jun 11, 2016

Major CSS refactor moving codebase over to BEM naming convention. Cleaned up components and added documentation.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jun 11, 2016

html-linter is throwing linter errors because of the new BEM naming convention.
It does not look immediately obvious to me how to get around this :(

@dstufft
Copy link
Member

dstufft commented Jun 11, 2016

We can probably just make html linting to shut up about that particular kind of error.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jun 12, 2016

@dstufft - FYI we will need to merge this PR on pypi-theme https://github.com/python/pypi-theme/pull/2 at the same time, so that the HTML/CSS remains in sync.

@dstufft
Copy link
Member

dstufft commented Jun 12, 2016

@nlhkabu pypi-theme doesn't auto deploy, so the easiest thing to do will be to merge that PR, then I'll make a release of pypi-theme and this PR can be updated to change the pypi-theme version.

@dstufft
Copy link
Member

dstufft commented Jun 12, 2016

By the way, I think you can tell html_linter.py to shut about about this by adding names to the disabled list in the Makefile#L118.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jun 12, 2016

By the way, I think you can tell html_linter.py to shut about about this by adding names to the disabled list in the Makefile#L118.

aha! Thank-you :)

I just added a few more things to my todo list on this PR (see #813 (comment)), but hopefully we can get it merged in the next few days :)

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jun 17, 2016

ok @dstufft this is ready to merge with a new release of pypi-theme :)

Closes #813

@dstufft dstufft merged commit 7c78ff2 into pypi:master Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants