-
Notifications
You must be signed in to change notification settings - Fork 1k
Css refactor #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css refactor #1263
Conversation
html-linter is throwing linter errors because of the new BEM naming convention. |
We can probably just make html linting to shut up about that particular kind of error. |
@dstufft - FYI we will need to merge this PR on pypi-theme https://github.com/python/pypi-theme/pull/2 at the same time, so that the HTML/CSS remains in sync. |
@nlhkabu pypi-theme doesn't auto deploy, so the easiest thing to do will be to merge that PR, then I'll make a release of pypi-theme and this PR can be updated to change the pypi-theme version. |
By the way, I think you can tell html_linter.py to shut about about this by adding |
aha! Thank-you :) I just added a few more things to my todo list on this PR (see #813 (comment)), but hopefully we can get it merged in the next few days :) |
Major CSS refactor moving codebase over to BEM naming convention. Cleaned up components and added documentation.