Admin package upload size text control should use MB instead of bytes #2471

theacodes · 2017-10-06T20:45:27Z

Decision:

The input in should be in MB and should just be converted to/from bytes in the backend.

Also:

It also might be a good idea to flash an error and redirect back to the detail page if you try to set a limit less then the current default minimum.

Additionally:

[The form field] would be a bit nicer as <input type="number" min={{ THE MINMUM SIZE }} ...> instead of as a text field. It might also make sense to include step="10" or something

theacodes · 2017-10-06T20:45:44Z

@dstufft I'm a PyPA member but not a member on this project so I can't assign myself.

* Uses a number field instead of a text field. * The text field now uses megabytes instead of bytes. * The detail page now shows the value in megabytes as well as the full value in bytes. * The detail page now shows "Default" as well as indicating what the default limit is in MB instead of just displaying "None". Unfortunately, I couldn't use "step" in the form field as it would have limited the input to multiples of the step value. Fixes pypi#2471

dstufft assigned theacodes Oct 6, 2017

theacodes mentioned this issue Oct 6, 2017

UI improvements to the admin interface for setting project upload limits #2473

Merged

dstufft closed this as completed in #2473 Oct 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin package upload size text control should use MB instead of bytes #2471

Admin package upload size text control should use MB instead of bytes #2471

theacodes commented Oct 6, 2017 •

edited

Loading

theacodes commented Oct 6, 2017

Admin package upload size text control should use MB instead of bytes #2471

Admin package upload size text control should use MB instead of bytes #2471

Comments

theacodes commented Oct 6, 2017 • edited Loading

theacodes commented Oct 6, 2017

theacodes commented Oct 6, 2017 •

edited

Loading