OIDC: More claims for GitHub's provider #11239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: #10645 (comment) |
di
reviewed
Apr 25, 2022
warehouse/migrations/versions/bb986a64761a_rename_githubprovider_fields.py
Outdated
Show resolved
Hide resolved
di
approved these changes
Apr 25, 2022
|
Refactored the migration to use renames 🙂 |
di
approved these changes
Apr 25, 2022
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
* [WIP] initial renamings and migration * migrations: bump revision * Revert "migrations: bump revision" This reverts commit 38035bd. * tests, warehouse: update tests * migrations: rename instead of drop/add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has added claims that allow us to attest to the repository owner's stable ID, which in turn allows us to prevent "account resurrection"-style attacks.
Needs test updates, but this should be functionally complete. The migration is primarily to make the comparisons during claim verification more straightforward.