move all record_event instances to send a request #13744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
commented
May 24, 2023
| @@ -369,28 +369,26 @@ def create_service(cls, context, request): | |||
|
|
|||
| @implementer(IProjectService) | |||
| class ProjectService: | |||
| def __init__(self, session, remote_addr, metrics=None, ratelimiters=None) -> None: | |||
| def __init__(self, session, metrics=None, ratelimiters=None) -> None: | |||
There was a problem hiding this comment.
biggest refactor here. removed remote_addr on service instantiation and made it required when calling the one method that uses it.
|
tempted to remove |
We should definitely do this, but in a separate PR. |
|
yes, yes, I omitted "in this pr" from that sentence |
di
approved these changes
May 24, 2023
miketheman
approved these changes
May 24, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step towards #8158, updates all
record_eventcalls to use arequest.