refactor: include existing ultranormalized index #14012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pypi#10498 and index was manually added via migration. At the time, SQLAlchemy 1.4 did not detect this un-declared change. Since SQLAlchemy 2.0, autogenerating a migration for the codebase wants to drop the index, since it's not declared on the table. Adding the correct column to the `__table_args__` means that the column name needs to be in scope, which it cannot be at the top of the table definition, so move it to the bottom, and add the existing Index. With this change in place, alembic no longer suggests that we delete the index, nor does it suggest any other operations. Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added
the
developer experience
ewdurbin
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10498 and index was manually added via migration. At the time, SQLAlchemy 1.4 did not detect this un-declared change.
Since SQLAlchemy 2.0, autogenerating a migration for the codebase wants to drop the index, since it's not declared on the table.
Adding the correct column to the
__table_args__means that the column name needs to be in scope, which it cannot be at the top of the table definition, so move it to the bottom, and add the existing Index.With this change in place, alembic no longer suggests that we delete the index, nor does it suggest any other operations.