Edit user profiles [WIP] #1847
Closed
Edit user profiles [WIP] #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 22, 2016 09:22
Closed
alex
reviewed
Mar 15, 2017
warehouse/accounts/views.py
Outdated
|
|
||
| if request.method == "POST" and form.validate(): | ||
| username = form.username.data | ||
| userid = user_service.find_userid(username) |
There was a problem hiding this comment.
This appears to let any user change any other user's data?
There was a problem hiding this comment.
👍 Anyway I just took over this PR, I'll be changing this.
|
Hi, @gsb-eng! In the Warehouse developer meeting today we decided that issue #423 belongs in the first milestone, the MVP for package maintainers. So this feature is a priority for us, and we'd love it if you or @karan had time to rebase and update this branch in the next few days! Thanks and best wishes. |
|
Closing as this is a bit stale, and since we'll be shipping this as part of the Maintainer MVP milestone. Thanks for taking a shot at this @gsb-eng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation to PR 1229 raised by @karan , it's still WIP
WIP
What can be edited:
Name
Password
#423
Future work needed:
Style the page
Allow editing username?
Allow editing email? This will likely be a separate form or page because there can be multiple emails and some can be primary.