block top-level module namespaces not covered by stdlib-list #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #2940, initial work failed to take this into consideration.
ewdurbin
force-pushed
the
stdliblist-holes
branch
from
7b2bf10 to
452280f
Compare
di
approved these changes
Feb 14, 2018
|
was going to ship changes in c07fbb3 separately, but just pushed them to try to rattle codecov.io loose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2940, initial work failed to take this into consideration.
one other thing to consider is situations noted in the initial report...
should we block packages like:
encodings.magicencodingor
xml.painvillethat "squat" by appearing to belong to top level namespaces?