Delete account

[di]

Fixes #2832.

@nlhkabu This just needs a quick glance.

With projects solely owned by the user:

Without any projects solely owned by the user:

Corresponding modal:

[nlhkabu]

Updated and ready on my side @di :)

Many projects

One project

No projects

[nlhkabu]

Also, not sure if this is just my local install... I'm getting a sqlalchemy error on /account/register/ on this branch:

sqlalchemy.exc.ProgrammingError: (psycopg2.ProgrammingError) relation "warehouse_admin_flag" does not exist
LINE 2: FROM warehouse_admin_flag 
             ^
 [SQL: 'SELECT warehouse_admin_flag.id AS warehouse_admin_flag_id, warehouse_admin_flag.description AS warehouse_admin_flag_description, warehouse_admin_flag.enabled AS warehouse_admin_flag_enabled \nFROM warehouse_admin_flag \nWHERE warehouse_admin_flag.id = %(id_1)s \n LIMIT %(param_1)s'] [parameters: {'id_1': 'disallow-new-user-registration', 'param_1': 1}] (Background on this error at: http://sqlalche.me/e/f405)

[nlhkabu]

Another thing @di - I noticed that there is no confirmation message when a user deletes their account. Is this normal?

[di]

@nlhkabu Looks great! The error is because there was a migration in #2967, you'll need to do a docker-compose run web python -m warehouse db upgrade head.

I'm not entirely sure what you mean by confirmation message, but I think you mean something like a green "Account successfully deleted" flash or something similar. We can't flash a message here because once the user is deleted, they are logged out and their session is destroyed.

We do have the modal, and there is an email sent to the primary email address with a notification that the account was deleted, so I think that should suffice.

[nlhkabu]

ok, thanks @di. I was thinking of a "Account successfully deleted" flash, but if we have no session, that makes sense :D