Add sole owner badge on lists of projects #4970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oo/warehouse into 3127-sole-owner-badge
|
|
di
reviewed
Oct 28, 2018
warehouse/manage/views.py
Outdated
|
|
||
| return { | ||
| "projects_owned": request.db.query(projects_owned).all(), | ||
| "projects_sole_owned": request.db.query(Project) |
There was a problem hiding this comment.
Small nit, can you reformat this line to be:
"projects_sole_owned": (
request.db.query(Project).join(with_sole_owner).order_by(Project.name).all()
),
|
|
di
reviewed
Oct 28, 2018
| <h3 class="package-snippet__title">{{ project.name }}</h3> | ||
| <h3 class="package-snippet__title">{{ project.name }} | ||
| {% if project.name in projects_sole_owned %} | ||
| <span class="badge package-snippet__sole-owner-badge">Sole owner</span> |
There was a problem hiding this comment.
Can you wrap this in a link to the collaboration management page?
<a href="{{ request.route_path('manage.project.roles', project_name=project.normalized_name) }}">
<span class="badge package-snippet__sole-owner-badge">Sole owner</span>
</a>
di
approved these changes
Oct 28, 2018
|
|
|
|
|
Thanks @rupali-saboo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3127, closes #4396.
Changes:
This is built on top of @gabrielgradinaru PR: #4396