Force user to explicitly select token scope, show warning if user scopes to account #6271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@woodruffw what do you think of the copy here? "have the same power as your account password" isn't technically true, as it will only work for package uploads... |
Contributor
Author
|
In addition to the warning, we could force users to explicitly select their scope, e.g.
|
Member
Yeah, that's true. How about "will be able to modify all of your projects"?
Great idea! I totally forgot this was possible 😅 |
Member
|
I'll take a look at adding the JS snippet. |
Member
|
Closing in favor of #6274. |
nlhkabu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6266
@woodruffw would you be able to write a small snippet of JS that toggles the visibility of the warning, depending on whether or not "Entire account (all projects)" is selected above?