Skip to content

Improve API UI #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Improve API UI #6288

merged 1 commit into from
Jul 29, 2019

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Jul 29, 2019

Closes #6257

Screenshot from 2019-07-29 06-48-50

  • Makes permissions explicit in token creation form
  • Lists permission and scope above API token display
  • Adds "Add another token" heading, when displaying API token

@nlhkabu nlhkabu requested review from woodruffw and ewdurbin July 29, 2019 05:55
@nlhkabu nlhkabu force-pushed the 6257-improve-create-token-ui branch from 9ef73a8 to 0bff1a4 Compare July 29, 2019 06:02
@nlhkabu nlhkabu force-pushed the 6257-improve-create-token-ui branch from 0bff1a4 to 80c5fb4 Compare July 29, 2019 19:24
@nlhkabu nlhkabu merged commit 86ebedb into master Jul 29, 2019
@nlhkabu nlhkabu deleted the 6257-improve-create-token-ui branch July 29, 2019 19:30
@Carreau
Copy link
Contributor

Carreau commented Jul 29, 2019

Thanks ! That Looks Great !

woodruffw added a commit to trail-of-forks/warehouse that referenced this pull request Jul 30, 2019
@woodruffw
warehouse: Re-add scope:user option
a436720 
Accidentally removed in pypi#6288.
ewdurbin pushed a commit that referenced this pull request Jul 31, 2019
@woodruffw @ewdurbin
warehouse: Allow maintainers to craft project tokens (#6301)
ba6bc19 
* warehouse: Allow maintainers to craft project tokens

* tests: Update against new project_names

* tests: Add project_names test

* warehouse: Route to project page instead of management page

This avoids 403s for tokens created by maintainers.

* warehouse: Simplify project_names

Use the user.projects relation.

* warehouse: Re-add scope:user option

Accidentally removed in #6288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@ewdurbin ewdurbin Awaiting requested review from ewdurbin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API Token form confusion
3 participants
@nlhkabu @Carreau @woodruffw