Skip to content

Add email templates for removed file from release #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

MVrachev
Copy link
Contributor

@MVrachev MVrachev commented Mar 5, 2020

Until now, when there are multiple contributors on a single
the project, if one of them deletes a file from certain release
the other contributors don't get any notification,
which is problematic.

Connected with issue #5714

Signed-off-by: Martin Vrachev [email protected]

@MVrachev MVrachev force-pushed the remove-version-file-email branch from 0c476ff to 6a171e5 Compare March 5, 2020 11:41
@MVrachev MVrachev force-pushed the remove-version-file-email branch from 6a171e5 to 0fd9d31 Compare March 9, 2020 17:03
@MVrachev
Copy link
Contributor Author

MVrachev commented Mar 9, 2020

I updated my pr addressing your comment @di.

@MVrachev MVrachev force-pushed the remove-version-file-email branch from 0fd9d31 to db8dcef Compare March 12, 2020 18:41
@MVrachev
Copy link
Contributor Author

MVrachev commented Mar 12, 2020

Thank you for the comprehensive and detailer review @di!
I addressed your suggestions.

@MVrachev
Copy link
Contributor Author

MVrachev commented Mar 12, 2020

Based on your feedback @di I created a new pr refactoring my older code where I add email templates for project/release removal.
#7530

@MVrachev MVrachev force-pushed the remove-version-file-email branch from db8dcef to 6c0c8b7 Compare March 18, 2020 17:58
@MVrachev
Copy link
Contributor Author

MVrachev commented Mar 18, 2020

Removed translations for an owner and a maintainer.

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove all translations from the email templates.

Until now, when there are multiple contributors on a single
the project, if one of them deletes a file from certain release
the other contributors don't get any notification,
which is problematic.

Connected with issue pypi#5714

Signed-off-by: Martin Vrachev <[email protected]>
@MVrachev MVrachev force-pushed the remove-version-file-email branch from 6c0c8b7 to 4a25fc6 Compare March 19, 2020 19:17
@MVrachev
Copy link
Contributor Author

Removed all translations.

@di di merged commit f8c866c into pypi:master Mar 20, 2020
@di
Copy link
Member

di commented Mar 20, 2020

Thanks!

@MVrachev MVrachev deleted the remove-version-file-email branch March 21, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants