Skip to content

Conversation

@adisbladis
Copy link
Member

@adisbladis adisbladis commented Nov 1, 2024

Related issue pyproject-nix/uv2nix#43

@adisbladis adisbladis marked this pull request as draft November 1, 2024 09:24
@adisbladis adisbladis marked this pull request as ready for review November 3, 2024 09:11
adisbladis added a commit to pyproject-nix/uv2nix that referenced this pull request Nov 3, 2024
This introduces a breaking change.

Previously `dev-dependencies` were remapped as optional dependencies, still named `dev-dependencies`:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev-dependencies" ];
};
```

Will now be written simply as `dev`, refering to a dependency group, and not an optional feature:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev" ];
};
```

This mirrors new Uv behaviour introduced in astral-sh/uv#8272.
See pyproject-nix/pyproject.nix#170 for pyproject.nix changes.
adisbladis added a commit to pyproject-nix/uv2nix that referenced this pull request Nov 3, 2024
This introduces a breaking change.

Previously `dev-dependencies` were remapped as optional dependencies, still named `dev-dependencies`:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev-dependencies" ];
};
```

Will now be written simply as `dev`, refering to a dependency group, and not an optional feature:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev" ];
};
```

This mirrors new Uv behaviour introduced in astral-sh/uv#8272.
See pyproject-nix/pyproject.nix#170 for pyproject.nix changes.
adisbladis added a commit to pyproject-nix/uv2nix that referenced this pull request Nov 3, 2024
This introduces a breaking change.

Previously `dev-dependencies` were remapped as optional dependencies, still named `dev-dependencies`:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev-dependencies" ];
};
```

Will now be written simply as `dev`, refering to a dependency group, and not an optional feature:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev" ];
};
```

This mirrors new Uv behaviour introduced in astral-sh/uv#8272.
See pyproject-nix/pyproject.nix#170 for pyproject.nix changes.
@adisbladis adisbladis merged commit 2ff6add into master Nov 3, 2024
23 checks passed
adisbladis added a commit to pyproject-nix/uv2nix that referenced this pull request Nov 3, 2024
This introduces a breaking change.

Previously `dev-dependencies` were remapped as optional dependencies, still named `dev-dependencies`:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev-dependencies" ];
};
```

Will now be written simply as `dev`, refering to a dependency group, and not an optional feature:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev" ];
};
```

This mirrors new Uv behaviour introduced in astral-sh/uv#8272.
See pyproject-nix/pyproject.nix#170 for pyproject.nix changes.
adisbladis added a commit to pyproject-nix/uv2nix that referenced this pull request Nov 3, 2024
This introduces a breaking change.

Previously `dev-dependencies` were remapped as optional dependencies, still named `dev-dependencies`:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev-dependencies" ];
};
```

Will now be written simply as `dev`, refering to a dependency group, and not an optional feature:
``` nix
virtualenv = editablePythonSet.mkVirtualEnv "hello-world-dev-env" {
  hello-world = [ "dev" ];
};
```

This mirrors new Uv behaviour introduced in astral-sh/uv#8272.
See pyproject-nix/pyproject.nix#170 for pyproject.nix changes.
@adisbladis adisbladis deleted the pep735 branch November 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants