Skip to content

[WIP] pyrepl from PyPy #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

[WIP] pyrepl from PyPy #2

wants to merge 31 commits into from

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Mar 10, 2019 •
edited
Loading

blueyed added 5 commits March 10, 2019 20:31
@blueyed
Copy pyrepl from PyPy
f620a2f 
pypy/lib_pypy/pyrepl => pyrepl
pypy/extra_tests/test_pyrepl => testing

py3.6 branch

Ref: https://bitbucket.org/pypy/pypy/issues/2971
@blueyed
tests: test_raw_input: test raw_input (again)
cd77c02
@blueyed
raw_input: pass returns_unicode properly
d7e72e6 
It was passing in `reader` for `returns_unicode` (which should be a
bool).  This does not change the behavior, but is less confusing.
@blueyed
Fix/re-enable quoted_insert: use self.evt.data
2c0e489
@blueyed
Fix/improve qIHelp (for quoted-insert)
73a5249 
Fix test_quoted_insert_repeat to use "key" instead of "self-insert" to
actually use qIHelp.
@codecov-io
Copy link

codecov-io commented Mar 10, 2019 •
edited
Loading

Codecov Report

Merging #2 into master will increase coverage by 0.37%.
The diff coverage is 68.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage    60.7%   61.08%   +0.37%     
==========================================
  Files          22       22              
  Lines        2171     2238      +67     
  Branches      317      326       +9     
==========================================
+ Hits         1318     1367      +49     
- Misses        743      764      +21     
+ Partials      110      107       -3
Impacted Files Coverage Δ
pyrepl/console.py 71.79% <ø> (ø) ⬆️
testing/test_wishes.py 100% <ø> (ø) ⬆️
pyrepl/completing_reader.py 29.93% <0%> (ø) ⬆️
pyrepl/unix_eventqueue.py 97.33% <100%> (ø) ⬆️
testing/test_reader.py 100% <100%> (ø)
pyrepl/commands.py 58.9% <100%> (+2.15%) ⬆️
pyrepl/historical_reader.py 39.9% <100%> (-0.29%) ⬇️
testing/test_basic.py 100% <100%> (ø) ⬆️
pyrepl/unix_console.py 53.16% <100%> (+0.72%) ⬆️
testing/test_unix_reader.py 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2394f1...63ce133. Read the comment docs.

blueyed added 24 commits March 11, 2019 00:05
@blueyed
Keep py2 fixes from master
967eb91
@blueyed
test_readline: keep tests from master
9c666bb
@blueyed
fixup! Keep py2 fixes from master
fdcdd74
@blueyed
fixup! test_readline: keep tests from master
ae41c26
@blueyed
fixup! fixup! Keep py2 fixes from master
159e3a1
@blueyed
Fix read_history_file/write_history_file for py2
a25b7b7
@blueyed
fixup! fixup! fixup! Keep py2 fixes from master
998e379
@blueyed
testing/test_unix_reader.py from master
ae4b8a2
@blueyed
keep things from master for test_unix_reader
9308882
@blueyed
fixup! keep things from master for test_unix_reader
53d0a75
@blueyed
keep ncursesw fix
c91fcd2
@blueyed
fixup! Fix/improve qIHelp (for quoted-insert)
d8636d1
@blueyed
remove testing/conftest.py: pytest_ignore_collect should not be needed
07a784d
@blueyed
testing/__init__.py: no trailing newline
93d6868
@blueyed
keep pyrepl/unix_eventqueue.py mostly from master
87b1951
@blueyed
tests: add test_write_history_file (failing on master)
e10e082
@blueyed
write_history_file: do not nuke history on errors
ff54181
@blueyed
keep 33aac3f from master
f5c935f
@blueyed
Keep code cleanup from master
4d3648c
@blueyed
fixup! write_history_file: do not nuke history on errors
7f1a049
@blueyed
fixup! raw_input: pass returns_unicode properly
2d61f10
@blueyed
fixup! Keep code cleanup from master
19d6636
@blueyed
pyrepl/completing_reader.py: keep most of master, flake8 clean
40cb460
@blueyed
Remove pyrepl/_minimal_curses.py
655cc50 
PyPy appears to ship its own, and it is not required for CPython.
blueyed added 2 commits March 16, 2019 13:00
@blueyed
keep pyrepl/cmdrepl.py from master
9a0ff78
@blueyed
remove pyrepl/unicodedata_.py
63ce133 
Not required due to 640d111.
Should also have been removed in PyPy py3.6 branch with 58411:be161e2bc46a.
@blueyed
Copy link
Collaborator Author

blueyed commented Apr 24, 2019

Picked history nuking on py3 into https://github.com/blueyed/pyrepl/pull/4..
What a mess.

@blueyed blueyed mentioned this pull request Jul 27, 2019
Open
12 tasks
@blueyed blueyed mentioned this pull request Aug 15, 2019
Merged
@blueyed blueyed mentioned this pull request Apr 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @codecov-io