Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

declare dependencies #9

Closed
thomasleveil opened this issue Nov 30, 2020 · 1 comment · Fixed by #11
Closed

declare dependencies #9

thomasleveil opened this issue Nov 30, 2020 · 1 comment · Fixed by #11
Assignees
@pyropy
Labels
bug Something isn't working

Comments

@thomasleveil
Copy link

shouldn't setup.py declare it's dependencies on :

  • fastapi >= ??
  • python-socketio >= ???
@pyropy
Copy link
Owner

pyropy commented Nov 30, 2020

Thanks for reporting the issue, I must have missed that out. Will take a look on it ASAP 👀

@pyropy pyropy self-assigned this Nov 30, 2020
@pyropy pyropy added the bug Something isn't working label Nov 30, 2020
@pyropy pyropy mentioned this issue Dec 1, 2020
Merged
@pyropy pyropy closed this as completed in #11 Dec 1, 2020
pyropy added a commit that referenced this issue Dec 1, 2020
@pyropy
Merge pull request #11 from pyropy/#9-add-missing-dependencies
3d1cc87 
#9 add missing dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pyropy pyropy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#9 add missing dependencies pyropy/fastapi-socketio
2 participants
@thomasleveil @pyropy