In tests use -m instead of -k for running tests by marker expressions #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would do that other way round. I would merge this pull request (as it is only tests update and is quite obvious) and then I would update #282 to check if tests pass :) |
|
Then we need the help of @pytest-dev/pytest-bdd-admin, as I don't have superpowers to merge this PR. |
|
I thought you have :D Could you please approve this PR to let them know that you are fine with changes? |
youtux
approved these changes
Jan 12, 2019
|
Other option is to merge this PR to #282 . What do you think? |
|
Also fine to me, since we are effectively trying to fix CI builds due to pytest changes. |
|
Merged to #282 in the forked repository |
|
I still don't have superpowers, @sliwinski-milosz |
|
Superpowers, I hear? 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests we use
-kfor running tests by markers (tags). That approach works forpytest<4.1.0. Pytest documentation says nothing about ability to use-kfor selecting markers.https://docs.pytest.org/en/latest/usage.html#specifying-tests-selecting-tests
Correct approach is to use
-mfor markers.Latest
pytest==4.1.0removes some legacy code related to markers. My guess is that it also removed ability to use-kfor selecting markers:(removal of
store_legacy_markinfofunction)pytest-dev/pytest@9f9f6ee#diff-b1e6724759432cb1b166981e45a4a25cL238
Please note that some tests are failing because of the warnings that break regex checks of tests results. Those warnings are fixed in #282
This and mentioned above pull request together make our tests green again.