Fix performance regression from version 4.0.0 #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 95.24% 95.25%
=======================================
Files 49 49
Lines 1705 1707 +2
Branches 169 169
=======================================
+ Hits 1624 1626 +2
Misses 46 46
Partials 35 35
Continue to review full report at Codecov.
|
|
Version 4.0.1 is released to PyPI with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#384 introduced a performance regression caused by
inspect.stack().To give an idea of the size of the problem, collecting tests from a test suite with ~7000 test is 7x slower than it used to be in pytest 3.2.1.
This PR addresses the issue by using lower-level api calls (sys._getframe + inspect.getframeinfo)