AttributeError: 'Function' object has no attribute 'get_marker'

[rossmacarthur]

I just started getting the following error with pytest-cov v2.6.0, pytest v4.1.0 on Python 3.4.6, PyPy, and PyPy3

self = <pytest_cov.plugin.CovPlugin object at 0x110f365c0>, item = <Function test_x>

    @compat.hookwrapper
    def pytest_runtest_call(self, item):
>       if (item.get_marker('no_cover')
                or 'no_cover' in getattr(item, 'fixturenames', ())):
E               AttributeError: 'Function' object has no attribute 'get_marker'

../.pyenv/versions/3.4.9/envs/venv/lib/python3.4/site-packages/pytest_cov/plugin.py:289: AttributeError

How to replicate

• Create a virtualenv with Python 3.4.9

• pip install pytest==4.1.0 pytest-cov==2.6.0

• Create something.py with the following contents:

def test_x():
    assert True

• Run pytest --cov=something something.py

Pytest output

========================================================== test session starts ===========================================================
platform darwin -- Python 3.4.9, pytest-4.1.0, py-1.7.0, pluggy-0.8.0 -- /Users/ross/.pyenv/versions/3.4.9/envs/venv/bin/python
cachedir: .pytest_cache
rootdir: /Users/ross/temp, inifile:
plugins: cov-2.6.0
collected 1 item

something.py::test_x FAILED                                                                                                        [100%]

================================================================ FAILURES ================================================================
_________________________________________________________________ test_x _________________________________________________________________

self = <pytest_cov.plugin.CovPlugin object at 0x110f365c0>, item = <Function test_x>

    @compat.hookwrapper
    def pytest_runtest_call(self, item):
>       if (item.get_marker('no_cover')
                or 'no_cover' in getattr(item, 'fixturenames', ())):
E               AttributeError: 'Function' object has no attribute 'get_marker'

../.pyenv/versions/3.4.9/envs/venv/lib/python3.4/site-packages/pytest_cov/plugin.py:289: AttributeError

---------- coverage: platform darwin, python 3.4.9-final-0 -----------
Name           Stmts   Miss  Cover
----------------------------------
something.py       2      1    50%

======================================================== 1 failed in 0.07 seconds ========================================================

[rossmacarthur]

Possibly because of this pytest-dev/pytest#4564?

[RonnyPfannschmidt]

this should have been triggering errors since pytest==4.0.0

[bbernays]

We are seeing the same error with latest version of pytest.

OK: pytest==4.02 with pytest-cov-2.6.0
FAILS: pytest==4.1.0 with pytest-cov-2.6.0

[blueyed]

Fixed in #253.

[blueyed]

pytest-cov is not tested against current/newer pytest versions.
It is being worked on in #240.

[nicoddemus]

this should have been triggering errors since pytest==4.0.0

Indeed, that was the idea... can anyone explain why was that not the case? Perhaps migrating directly from 3.X to 4.1 caused this?

[RonnyPfannschmidt]

@nicoddemus i just noted the detail issue - remember get_marker function it was only documented deprecated, but the actual warnings got triggered by usage of the return value

https://github.com/pytest-dev/pytest/pull/4564/files#diff-c4fc03c3a0d271a27a48958fb69a6b6f basically