Skip to content

pytest 4.1 compatibility #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2019
Merged

pytest 4.1 compatibility #20

merged 2 commits into from
Feb 3, 2019

Conversation

kondratyev-nv
Copy link

Fixes #18

@ropez
Copy link
Collaborator

ropez commented Feb 2, 2019

Thanks a lot. Will review this, and publish a new build, as soon as I can.

@ropez
Copy link
Collaborator

ropez commented Feb 2, 2019

Looking at test output in travis.ci, there are a lot of invalid escape sequences in regular expressions:

test/test_collect.py:31
  /home/travis/build/ropez/pytest-describe/test/test_collect.py:31: DeprecationWarning: invalid escape sequence \s
    "\s*<DescribeBlock (')?describe_something(')?>",

These needs to be fixed, probably by using "raw" string literals, i.e change "\s*..." to r"\s*...".

Example output: https://travis-ci.org/ropez/pytest-describe/jobs/487850038

@ropez
Copy link
Collaborator

ropez commented Feb 3, 2019

I'll take care of the regexps

@ropez ropez merged commit 74a107e into pytest-dev:master Feb 3, 2019
@kondratyev-nv
Copy link
Author

Thank you! Sorry for a late reply, was going to fix it now, but you were faster :)

@ropez
Copy link
Collaborator

ropez commented Feb 3, 2019

It's now published as version 0.12.0. Thank you @kondratyev-nv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants