Skip to content

Conversation

kingbuzzman
Copy link
Member

No description provided.

@kingbuzzman kingbuzzman requested a review from Copilot August 13, 2025 08:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project's packaging configuration by replacing PEP 735 dependency groups with the more widely supported optional dependencies format. The changes update both the pyproject.toml configuration and the tox.ini file to use the standardized extras syntax instead of the newer dependency-groups feature.

  • Converts [dependency-groups] to [project.optional-dependencies] in pyproject.toml
  • Updates tox.ini to use extras instead of dependency_groups for all test environments

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Migrates from dependency-groups to optional-dependencies format
tox.ini Updates all testenv configurations to use extras instead of dependency_groups
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@kingbuzzman kingbuzzman marked this pull request as ready for review August 13, 2025 12:32
@kingbuzzman kingbuzzman enabled auto-merge (squash) August 13, 2025 12:35
@kingbuzzman kingbuzzman merged commit 3f36d49 into main Aug 13, 2025
21 checks passed
@kingbuzzman kingbuzzman deleted the dev/modernize-pyproject branch August 13, 2025 12:37
@webknjaz
Copy link
Member

webknjaz commented Aug 13, 2025

@kingbuzzman why did you say "modernize" in the title but the diff shows the opposite? It's rather wrong to expose public API for dev-related deps. Do you expect the users to do pip install 'pytest-django [docs]'?

@kingbuzzman
Copy link
Member Author

@webknjaz -- I completely misunderstood PEP735 -- I'll revert it as soon as codecov + readthedocs get their act together.

kingbuzzman added a commit that referenced this pull request Aug 13, 2025
kingbuzzman added a commit that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants