Skip to content

Conversation

kingbuzzman
Copy link
Member

Lowest risk

@kingbuzzman kingbuzzman requested a review from Copilot August 14, 2025 14:16
@kingbuzzman kingbuzzman marked this pull request as ready for review August 14, 2025 14:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all ANN (type annotation) type ignores from the Ruff configuration and adds proper type annotations throughout the codebase to fix the linting violations.

  • Adds comprehensive type annotations to function parameters and return types
  • Introduces new type aliases _User and _UserModel for better type safety with Django user models
  • Updates imports to support proper type checking with TYPE_CHECKING blocks

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Removes ANN-related ignore rules from Ruff configuration
pytest_django/django_compat.py Adds type aliases for Django user models
pytest_django/fixtures.py Adds type annotations to fixture functions and classes
pytest_django/plugin.py Adds type annotations to internal functions
pytest_django/live_server_helper.py Adds type annotation to __add__ method
pytest_django/asserts.py Adds comprehensive type annotations to assertion functions
tests/test_fixtures.py Adds type annotations and updates test function signatures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@kingbuzzman kingbuzzman requested a review from bluetech August 14, 2025 14:59
@kingbuzzman kingbuzzman merged commit cc73b3b into main Aug 15, 2025
21 checks passed
@kingbuzzman kingbuzzman deleted the dev/ruff-rules branch August 15, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant