Fix classmethod check for mixin case #618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a case of using a mixin on my test classes that started failing with 3.3.0 in upgrade PR adamchainz/django-mysql#484. It was caused by pytest-dev#598. It looks like this was actually a latent failure in the way `_classmethod_is_defined_at_leaf` was picking the 'super method' - it would iterate further up the tree despite coming across the next method in the resolution chain. Also by not using `__mro__` the order of the base classes wasn't strictly being observed, although I don't think that affects my mixin case. Added a test that fails before and passes after.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 92.28% 92.31% +0.02%
==========================================
Files 32 32
Lines 1698 1704 +6
Branches 142 142
==========================================
+ Hits 1567 1573 +6
Misses 94 94
Partials 37 37
Continue to review full report at Codecov.
|
Contributor
blueyed
approved these changes
Jun 18, 2018
Contributor
blueyed
left a comment
blueyed
left a comment
There was a problem hiding this comment.
LGTM, pushed a fixup to ignore branch coverage with the for-loop.
Member
Author
|
🍝 |
beyondgeeks
pushed a commit
to beyondgeeks/django-pytest
that referenced
this pull request
Sep 6, 2022
Fixes regression in #598. It looks like this was actually a latent failure in the way `_classmethod_is_defined_at_leaf` was picking the 'super method' - it would iterate further up the tree despite coming across the next method in the resolution chain. Also by not using `__mro__` the order of the base classes wasn't strictly being observed, although I don't think that affects my mixin case. Added a test that fails before and passes after. Closes pytest-dev/pytest-django#618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case of using a mixin on my test classes that started failing with 3.3.0 in upgrade PR adamchainz/django-mysql#484. It was caused by #598.
It looks like this was actually a latent failure in the way
_classmethod_is_defined_at_leafwas picking the 'super method' - it would iterate further up the tree despite coming across the next method in the resolution chain. Also by not using__mro__the order of the base classes wasn't strictly being observed, although I don't think that affects my mixin case.Added a test that fails before and passes after.